Trinity Hobbits Integration

jrhea commented 5 years ago

This bounty will be awarded to the team or individual integrating hobbits as defined by the specification of the wire protocol and the specification of the gossip protocol into the Trinity client.

Acceptance criteria:

The implementation is delivered under a permissive open source license (MIT and/or ASL)
The implementation follows Python 3 best practices.
The implementation has significant test coverage as unit tests.
The implementation is integrated with continuous integration and test coverage.
The Trinity client is able to peer with itself and finalize blocks

Additional Info:

Trinity client: https://github.com/ethereum/trinity Hobbits specifications: https://github.com/deltap2p/hobbits

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 5.0 ETH (1277.42 USD @ $255.48/ETH) attached to it as part of the @PegaSysEng fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $88,919.98 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 1 week, 5 days ago. Please review their action plans below:

1) ankitchiplunkar has applied to start work _(Funders only: approve worker | reject worker)_.

I have worked on bounties related to web3.py and trinity before. I want to learn more about eth2.0 and this implementation can be a great learning exercise. 2) ivanvpan has applied to start work _(Funders only: approve worker | reject worker)_.

Hey Jonny, I applied to do the Python Hobbit implementation and then spent much of the day looking at the Trinity architecture. It looks quiet nice and modular and I think it'll be a pleasure to work with. I'd try to find a communication channel with the team, cause it seems I'm missing some obvious things, for example how they run the beacon chain code.

Overall the game plan would be:

Find how to run the client in eth2 mode. Nothing obvious in the docs or the command line parameters.
Find the code for the networking process that eth2 code connects to. (It seems to exist because there is an interface for external libp2p process in the code).
Provide an alternative networking process and ask the devs how they would prefer to switch between libp2p and hobbit.
Implement the tcp connection and hobbit enconding/decoding.

After doing some research I can break code delivery into more concrete milestones.

Questions I have for you are similar to the ones in my proposal for Hobbits in Python bounty:

Your descriptions say that the gossip protocol should be implemented, yet does not mention the RPC stuff. Is that so?
I could ask contributors to the Hobbit repo, but the examples and implementations are mix between EWP 0.1 and 0.2. I assume 0.2 is the current and the feature of explicitly specifying compression and serialization has been abandoned.

I am quiet efficient and I think I can deliver this project promptly. I am also super excited by the idea of working on an Ethereum client. It's where I'd love to see my career go in general. 3) nanspro has been approved to start work.

I'd really like to apologize for being inactive for last 2 weeks but 3 days back i resumed the work and was observing renaynay's prysm integration to get more idea. I wrote the python client for hobbits and have already familiarized myself with trinity architecture so i guess i can really finish this. If you can approve me again i'll keep sharing my progress on github. Thank you and again sorry for the inactivity!!

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

@gitcoinbot :heart: I just completed the python implementation for hobbits so will start working on this from tomorrow. @jrhea you can expect it to be done within 8-9 days.

jrhea commented 5 years ago

@nanspro working with some other teams today to make the spec a little bit more coherent for when you integrate into Trinity. I will message you here when it is done

nanspro commented 5 years ago

Sounds good @jrhea Trinity offers different types of plugins so my guess is that we'll need a plugin which will spawn their own isolated process and will interact with other peers to get info.

I am reading more about these plugins and how they interact with the event_bus. Let me know when it is ready!!

jrhea commented 5 years ago

@nanspro here is a PR for the revised spec. It shouldn't affect the work you have done so far (if so it will be minimal). https://github.com/deltap2p/hobbits/pull/15. Feel free to leave comments and open issues/PRs

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

Have forked the repo and working on understanding how beacon nodes communicate

nanspro commented 5 years ago

@jrhea i am currently working on this but due to inactivity i was removed. I will definitely try to finish it by this weekend and will keep updating you with my progress!!

jrhea commented 5 years ago

@nanspro I think I removed u on accident. I will add u back. R u still interested?

nanspro commented 5 years ago

@jrhea yes i am really interested and hoping to finish it ASAP.

jrhea commented 5 years ago

Excellent...sorry for the mishap.

FYI, take a look at the new hobbits spec. it explains the ETH2 specific message format more concisely: https://github.com/deltap2p/hobbits/blob/41d928ed12523468aab657a9ae1bd658468fa0c9/specs/spec.md

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

Ping pong worked between nodes and now moving to specific rpc calls

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

Just debugging some errors while importing my python impln. Gonna push my significant progress this weekend(day after tomorrow)

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

Some hackathons and exams led to delay. Really sorry for that. I plan to submit my progress this weekend!!

gitcoinbot commented 5 years ago

@nanspro Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@nanspro due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

nanspro commented 5 years ago

Got busy with exams and this hackathon. Resuming in 3 days, hard deadline at 21st. Will stop otherwise!!

jrhea commented 5 years ago

Bounty Canceled

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 5.0 ETH (1036.64 USD @ $207.33/ETH) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin Slack
$156,688.69 more funded OSS Work available on the Gitcoin Issue Explorer

Consensys / protocol-BountiedWork

Trinity Hobbits Integration #18

Acceptance criteria:

Additional Info: