Consensys / quorum-kubernetes

Helm charts for Hyperledger Besu and GoQuorum
Apache License 2.0
116 stars 127 forks source link

Migration Plan from kubernetes.io/azure-file to file.csi.azure.com in Azure AKS v1.26 and Compatibility with Kubernetes v1.27 #219

Closed YosukeAbe47 closed 7 months ago

YosukeAbe47 commented 9 months ago

I am currently operating quorum-kubernetes using Azure's AKS version 1.26. With the transition to Kubernetes version 1.26, kubernetes.io/azure-file has become deprecated, yet it is still being used in the following section: https://github.com/Consensys/quorum-kubernetes/blob/master/helm/charts/goquorum-node/templates/node-storage.yaml#L10C2-L10C2

Is there any plan to address this? While it seems that Azure has no plans yet to remove the driver, would it be alright to migrate from kubernetes.io/azure-file to file.csi.azure.com? In that case, I am considering changing the provisioner and proceeding with the migration as described in Azure's documentation here: https://learn.microsoft.com/en-US/azure/aks/csi-migrate-in-tree-volumes#create-a-dynamic-volume Also, would there be any issue in updating Kubernetes to version 1.27 afterwards?

nowjean commented 7 months ago

@YosukeAbe47 Please view my PR. #226

I have customized and used my own azue file storageClass for private storage account. So, I didn't realize this issue. After merge these PR: #227 #226, This Helm chart working correctly in AKS 1.27!
If you want use this chart before merge above PRs, you can edit your chart first.

Thanks for sharing!

YosukeAbe47 commented 7 months ago

Thanks for your support!