Consensys / quorum-kubernetes

Helm charts for Hyperledger Besu and GoQuorum
Apache License 2.0
119 stars 128 forks source link

Incorrect static-nodes.json file created when installing validators #222

Closed conanoc closed 1 month ago

conanoc commented 9 months ago

This is the static-nodes.json after I install besu-genesis chart.

% kubectl get configmap besu-peers -o jsonpath='{.data.static-nodes\.json}'
[
"enode://4875ce438f4bfe232105b84108b122b27f1f0d8d1ff45749a56c50cfa164391161839fca2e5835e3516b3c1b98f5ba6883822559618ae4d6c0c33993fa5692b9@besu-node-validator-1-0.besu-node-validator-1.ncc-baas2.svc.cluster.local:30303?discport=0"
,"enode://fdb2c527babc129864bd0fc887b54fca50ce5e711a6193107b10dfd1473c854b7d9d9b90926c8aecba795375660cece34e296f9070004e1d062a4122011fa5b5@besu-node-validator-2-0.besu-node-validator-2.ncc-baas2.svc.cluster.local:30303?discport=0"
,"enode://8b44a7b5024309af3c8e622fcc9b1bc20da25d825a6b9dbb04c0db7de61949eccc1db2fe1485c1c40e30a2529645e7388bf57b05deacf1596ced99cd3044548b@besu-node-validator-3-0.besu-node-validator-3.ncc-baas2.svc.cluster.local:30303?discport=0"
,"enode://63bfcc33333e36fa85c93566b6e1f17348ba130fc4940577c0a685064f49f8cc12fa82da809204655f6210387c208ccc5da679521fad7705d777672b025cf0e4@besu-node-validator-4-0.besu-node-validator-4.ncc-baas2.svc.cluster.local:30303?discport=0"
]

The static-nodes.json changed as below after I installed validator-1 without any boot nodes.

% kubectl get configmap besu-peers -o jsonpath='{.data.static-nodes\.json}'                    
[
  "enode://2af58423d5d095478d7b13a56ca3ad0118ca81b310524e6ce880702697f916e80aebcbf2af9bab66696880483c0e988f2503e1556497a858d93b897dd5758734@besu-node-validator-1-0.besu-node-validator-1.ncc-baas2.svc.cluster.local:30303?discport=0",
  "enode://4875ce438f4bfe232105b84108b122b27f1f0d8d1ff45749a56c50cfa164391161839fca2e5835e3516b3c1b98f5ba6883822559618ae4d6c0c33993fa5692b9@besu-node-validator-1-0.besu-node-validator-1.ncc-baas2.svc.cluster.local:30303?discport=0",
  "enode://63bfcc33333e36fa85c93566b6e1f17348ba130fc4940577c0a685064f49f8cc12fa82da809204655f6210387c208ccc5da679521fad7705d777672b025cf0e4@besu-node-validator-4-0.besu-node-validator-4.ncc-baas2.svc.cluster.local:30303?discport=0",
  "enode://8b44a7b5024309af3c8e622fcc9b1bc20da25d825a6b9dbb04c0db7de61949eccc1db2fe1485c1c40e30a2529645e7388bf57b05deacf1596ced99cd3044548b@besu-node-validator-3-0.besu-node-validator-3.ncc-baas2.svc.cluster.local:30303?discport=0",
  "enode://fdb2c527babc129864bd0fc887b54fca50ce5e711a6193107b10dfd1473c854b7d9d9b90926c8aecba795375660cece34e296f9070004e1d062a4122011fa5b5@besu-node-validator-2-0.besu-node-validator-2.ncc-baas2.svc.cluster.local:30303?discport=0"
]

There are two besu-node-validator-1-0 in the static nodes list.

joshuafernandes commented 1 month ago

Thankyou for raising this @conanoc - this is fixed in #242