Can't add tessera key to contract after adding using "At" button

Consensys / quorum-remix

Quorum plugin for Remix IDE

Apache License 2.0

15 stars 11 forks source link

Can't add tessera key to contract after adding using "At" button #2

Closed bmcd closed 4 years ago

bmcd commented 4 years ago

From Zhiyao After I use At button to get a private contract, I don’t find a way to add new Tessera public key to the existing private for checklist

bmcd commented 4 years ago

I don't want to be able to add more public keys to an already deployed contract, since that may make users think that doing so will extend the actual private contract to those recipients.

But it could be more clear that the privateFor field above applies to both Deploy and At. Not sure the best solution to this:

Show a warning when they use At to make sure that they specified the correct privateFor keys?
Move the privateFor selector down closer to the Deploy/At section?

zzy96 commented 4 years ago

I cannot see the privateFor keys dropdown when I tested it.

If that display can function well, I should feel comfortable with the current implementation. When a wrong group of Tessera public keys is selected, we can simply close it and reselect and use At to instantiate again.