Migrate to vm v7 - Githubissues

blitz-1306 commented 9 months ago

Preface

This is a PoC pull request to use https://github.com/ethereumjs/ethereumjs-monorepo/releases/tag/%40ethereumjs%2Fvm%407.0.0 and other relevant dependencies. List of VM changes can be found here.

[x] Update dependencies.
[x] All Buffer types changed to Uint8Array due to upstream changes.
- [x] Most of Buffer.from() are replaced with toBytes() or hexToBytes(). This is not necessarily correct, due to these functions require 0x prefix at the beginning of the input string.
- [x] Most of Buffer.toString("hex") are replaced with custom Uint8Array-to-hex conversion functions. This is not necessarily correct, due to these function adds 0x prefix at the beginning of the result string. This may cause issues.
- [x] Bytes equality is now done with equalsBytes() instead of Buffer.equals().
[x] VM removed EEI from the package. Its functionality is now provided by StateManager. So there are related adjustments to respect this change.
[x] Transaction data is now passed with TypedTransaction type.
[x] RLP is now released as a standalone dependency and therefore used in such way.

Codebase is still not runnable due to VM package moved to cjs / esm builds, and I wasn't able to configure TS and Jest to work with it properly.
```
Cannot find module '@ethereumjs/evm/dist/cjs/opcodes' from 'src/debug/sol_debugger.ts'
```
As mentioned above, there are several cases, when code should be debugged (regading 0x prefix of bytes-to-hex conversion).
Other VM-dependent packages didnt moved to v7 just yet, so maybe we should wait until they finish their migration first.

Regards.

nandubatchu commented 3 months ago

is this resolved?

cd1m0 commented 2 weeks ago

Fixed in another PR.