search

Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

fix: get-starknet execute txn not working in firefox #242

Closed stanleyyconsensys closed 2 months ago

stanleyyconsensys commented 2 months ago

This PR is to fix an issue whenever a request fire to snap, if any value in params is undefined, e.g

{
  data : 1,
  somekey: undefined
}

it will block by metamask superstruct due to firefox convert undefined to an object

this fix is to remove any incoming undefined params before send to snap

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud