Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

feat: show upgrade dialog on get-starknet calls #247

Closed khanti42 closed 1 month ago

khanti42 commented 1 month ago

This PR is to add upgrade dialog on below APIs where those are using by get-starknet:

if above APIS trigger with an Cairo 0, account contract, it will first display an dialog, then reject the request by throw an Error

image

khanti42 commented 1 month ago

I already merged latest changes from main (including the deployment check for executeTxn), but the PR #254 including these changes in release/2.3.0 is still open.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
5.7% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud