search

Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

feat: add waiting mode for create account #251

Closed stanleyyconsensys closed 1 month ago

stanleyyconsensys commented 1 month ago

Due to a issue of SF-636

This PR is to add waitForTransaction on create account rpc method, to allow the snap to wait for the deploy txn successfully land on L2

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed for 'consensys_starknet-snap-starknet-snap'

Failed conditions
70.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud