Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

feat: sf-640 revamp cicd workflow #255

Closed stanleyyconsensys closed 1 month ago

stanleyyconsensys commented 1 month ago

This PR is to clean up the CICD and try to standardise with metamask workflow if possible

New workflow: Main (trigger by any push or pull request to main, to test workflow and the code) image

Deploy (trigger by manual, allow deploy to dev,staging,prod) image

Existing workflow: lint-pr-title, terraform, release-please will remain the same

Removed workflow: e2e-tests -> removed with no use case e2e-tests-slack-notification -> removed with no use case storybook -> removed with no use case deploy-dev -> merged to deploy publish-npm-dev -> merged to deploy build-test -> merged to main

Note: In MM workflow, they dont have dev , staging deployment, but mostly 1 go to PROD by manual create a release PR request, and merge the PR, and then the pipeline will deploy to prod in Starknet workflow, we do it by auto create release PR when ever a push to main, and manual deploy to different env for more flexible choice, e.g we can deploy a version b4 release PR or after release PR

Ticket: https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-640

sonarcloud[bot] commented 1 month ago

Please retry analysis of this Pull-Request directly on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud