feat: transactionV3 support to pay in STRK - Githubissues

Consensys / starknet-snap

The MetaMask Snap for Starknet

https://snaps.consensys.net/starknet

Apache License 2.0

77 stars 27 forks source link

feat: transactionV3 support to pay in STRK #261

Closed khanti42 closed 3 months ago

khanti42 commented 3 months ago

Summary of changes :

Support for Transaction Versions:

Addition of Transaction Version Parameter:
Added transactionVersion to API request parameters and updated related type definitions in snapApi.
Included transactionVersion in utility functions like getAccountInstance, estimateFee, estimateFeeBulk, and executeTxn.
Conditional Handling Based on Transaction Version:
Implemented logic to set fee token based on the transaction version (V2 for ETH, V3 for STRK).

Enhanced Fee Token Management to support both V2 and V3 transaction :

UI Components Adjustments:
Added a dropdown for selecting the fee token (ETH or STRK) in the SendModal component.
Adjusted the SendSummaryModal component to display and calculate fees based on the selected fee token.

Code update details

Modified functions like declareContract, estimateFee, estimateFees, executeTxn, and sendTransaction to incorporate and use the selected fee token.

Dependency Updates:

Upgraded starknet dependency from ^4.22.0 to 6.7.0 in wallet-ui package (required to get constants for TRANSACTION_VERSION)

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud