Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

fix: add MetaMask Provider Detection and Initialization for MetaMaskSnapWallet #267

Closed khanti42 closed 2 weeks ago

khanti42 commented 3 weeks ago

This PR fixes #268

It enhances the MetaMaskSnapWallet implementation by adding support for detecting and initializing a MetaMask provider. Key changes include:

These improvements ensure that the MetaMaskSnapWallet can robustly detect and initialize MetaMask providers, enhancing the reliability and usability of the MetaMask integration. This update makes the get-starknet integration as minimalist as possible and facilitates further interaction with the starknet/get-starknet repo.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

khanti42 commented 2 weeks ago

Can't happen. Provider detection has to happen before remoteEntry.js is loaded.