search

Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
77 stars 27 forks source link

feat: allow txv3 in get-starknet execute txn #269

Closed khanti42 closed 1 month ago

khanti42 commented 3 months ago

get-starknet users (they are dapp dev) interact with the starknet blockchain by calling execute which has the following signature :

abstract execute(transactions: AllowArray<Call>, transactionsDetail?: InvocationsDetails): Promise<InvokeFunctionResponse>;

The InvocationsDetails type defined by starknet.js is as follow 

type InvocationsDetails = {
    nonce?: BigNumberish;
    maxFee?: BigNumberish;
    version?: BigNumberish;

The transaction version can be set there.

This is how we can handle the version on executeTxn rpc endpoint used by our federated module middleware.

stanleyyconsensys commented 3 months ago

i think the PR is not ready, shall we move it back to draft