Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

fix: add cache key for different env in CICD #270

Closed stanleyyconsensys closed 2 weeks ago

stanleyyconsensys commented 2 weeks ago

This PR is to fix a bug in the CICD pipeline when processiong “Deployments" workflow

if the same commit point deploy twice in different env, the latter deploy code will reuse the build from prev build from a cache, and lead to incorrect deployment

solution: adding the cache with key commit sha + '-' + env

jira: https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-651

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud