search

Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

fix: remove get balance from createAccount #272

Closed stanleyyconsensys closed 2 weeks ago

stanleyyconsensys commented 2 weeks ago

This PR is to fix, the get balance call is fail during create account

the solution is to remove the get balance call, as it doesnt needed , starknet.js will auto estimate for user,

Note: it may break tx v3, but we should fix it in tx v3, but not this PR

jira: https://consensyssoftware.atlassian.net/jira/software/projects/SF/boards/472?selectedIssue=SF-650

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud