Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
72 stars 25 forks source link

Bug report: after updating snap a new account was generated for me instead of using the current one #279

Open neklyud opened 2 weeks ago

neklyud commented 2 weeks ago

Sorry, guys, for ask you here, but I didn't find some support chat related with starknet-snap (discord link unavailable) After last update of snap, it generated me new account instead of using already existed. May be I am wrong in some actions, but I didn't find a way for solving this problem. On 1st pic I added that one account connected to my metamask, on second pic - result when I connected my metamask account to dapp - other account (why its happened?). Can someone suggest me way to restore previous account?

Снимок экрана 2024-07-06 в 14 11 43 Снимок экрана 2024-07-06 в 14 44 56

Metamask version 11.16.14

neklyud commented 2 weeks ago

Which factors except seed phrase can impacts on solution of account generation and is there are exist way for return access to acc using metamask seed phrase? May be I can install locally some prev version of snap and regenerate account in some other way?

khanti42 commented 1 week ago

Hi @neklyud thank you for reporting your issue. May I ask you if you had non zero balance in the first account ?

If this is the case then the following PRs #276 and #272 should solve it.

neklyud commented 1 week ago

@khanti42, thank you for answer As far as I understand, when this project is accepted, the balances will be synchronized. Will I have to perform any actions for this?

mhrynenko commented 5 days ago

Hi @neklyud thank you for reporting your issue. May I ask you if you had non zero balance in the first account ?

If this is the case then the following PRs #276 and #272 should solve it.

Hello! I saw there was a 2.9.0 release that should fix it, but unfortunately the issue still the same. I've had a non zero balance for STRK tokens, but now it always zero and absolutely another address. Is there any information about it?

I used Firefox MacOS Metamask 11.16.13 version and 2.9.0 of Starknet Snap

stanleyyconsensys commented 4 days ago

@mhrynenko We are not yet support STRK tokens for now, so i think you can first fund the account with eth , so the dapp can ask you to deploy (as it is required for cairo 0) and it will also force you upgrade the account to cairo 1 (which is a force requirement) then your strk token will recover

in order to use strk token, you will have to wait txV3 enabled

stanleyyconsensys commented 4 days ago

@neklyud we have released 2.9.0 , which should fix the issue for Cairo 0 account funded but not deployed

mhrynenko commented 3 days ago

@mhrynenko We are not yet support STRK tokens for now, so i think you can first fund the account with eth , so the dapp can ask you to deploy (as it is required for cairo 0) and it will also force you upgrade the account to cairo 1 (which is a force requirement) then your strk token will recover

in order to use strk token, you will have to wait txV3 enabled

Well, but If new account is deployed with another address, but tokens were sent to the old one, how will it sync them with each other?

neklyud commented 2 days ago

@khanti42 I am getting follow message after first deploy acc:

Unfortunately, you reached the maximum number of deploy tentatives allowed. Please try again in a couple of hours. Thank you for your comprehension.

stanleyyconsensys commented 18 hours ago

@neklyud no worry, it is expected, when we needed to confirm the tx on chain, we keep fetch the status for serval times but if the status is still pending, we will ask the user to come back later

but i do agree the message is confusing

@khanti42 i think we have to update the error message

stanleyyconsensys commented 18 hours ago

@mhrynenko i believe the account that you have token is cairo 0 account, which is our default account so im asking if u can fund this account to deploy

and afterward, it will ask you to upgrade this account

the new account is only visible when