search

Consensys / starknet-snap

The MetaMask Snap for Starknet
https://snaps.consensys.net/starknet
Apache License 2.0
74 stars 26 forks source link

refactor: revamp rpc `starkNet_extractPrivateKey ` #319

Closed khanti42 closed 3 weeks ago

khanti42 commented 1 month ago

This PR is to move starkNet_extractPrivateKey rpc from root folder to rpcs folder and adopt the sharable rpc handler from this PR https://github.com/Consensys/starknet-snap/pull/320

This PR also rename the RPC to starkNet_displayPrivateKey

Requirement:

Requires this PR to be merged first:

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud