search

Consensys / surya

A set of utilities for exploring Solidity contracts
Apache License 2.0
1.06k stars 118 forks source link

The describe command mishandles the `receive()` function #155

Closed maurelian closed 2 years ago

maurelian commented 2 years ago

What I did: Ran surya describe on this contract

I got this output: 

 +  AuctionHouse (IAuctionHouse, ReentrancyGuard)
... skipped output ...
    - [Ext] <Fallback> ($)
    - [Ext] <Fallback> ($)

Version:

surya --version
0.4.3-dev.2

Possible fix

Pretty sure this: https://github.com/ConsenSys/surya/blob/4340e703434e4314e778f558675c70d821714cf0/src/describe.js#L85-L86

Just needs to look more like this:

https://github.com/ConsenSys/surya/blob/4340e703434e4314e778f558675c70d821714cf0/src/graph.js#L200-L203

GNSPS commented 2 years ago

Thank you! ❤️