Consensys / surya

A set of utilities for exploring Solidity contracts
Apache License 2.0
1.06k stars 118 forks source link

Generating the graph with type casting address(...) as a function. #186

Closed tintinweb closed 10 months ago

tintinweb commented 10 months ago

see original: https://github.com/Consensys/vscode-solidity-auditor/issues/134

When generating a call graph, the extensions sees typecasting like address(this) or address(some contract/interface) as a function and this is not only incorrect, but also visually clutters the chart. See example: image I think the fix should be pretty easy on this, just adding logic to ignore a function if it's name is address since that's impossible anyway in Solidity because the term is reserved for the type.

GNSPS commented 10 months ago

Taking a look

GNSPS commented 10 months ago

90% fixed in PR #187. Not closing because there's 10% to go. 🙈

GNSPS commented 10 months ago

Closing because I realised the extra 10% need a major refactoring.