search

Consensys / surya

A set of utilities for exploring Solidity contracts
Apache License 2.0
1.09k stars 119 forks source link

Show "NO!" for methods open for external calls without modifiers #59

Closed jchittoda closed 6 years ago

jchittoda commented 6 years ago

I did some changes for md-report. It now shows "NO❗️" in Modifiers column for methods those are public/default/external and there are no modifiers present for the method.

This change would give reviewers the idea that this function call could have potential flaws. It has to be reviewed.

GNSPS commented 6 years ago

Hey @jchittoda ! Thank you for your contribution! 😄 Can you please point the PR to the develop branch?

jchittoda commented 6 years ago

@GNSPS Thanks. Created new PR for develop https://github.com/ConsenSys/surya/pull/60

Closing this one.