When no modifier and external calls show "NO❗️" for modifiers

Consensys / surya

A set of utilities for exploring Solidity contracts

Apache License 2.0

1.09k stars 119 forks source link

When no modifier and external calls show "NO❗️" for modifiers #60

Closed jchittoda closed 6 years ago

jchittoda commented 6 years ago

I did some changes for md-report. It now shows "NO❗️" in Modifiers column for methods those are public/default/external and there are no modifiers present for the method.

This change would give reviewers the idea that this function call could have potential flaws. It has to be reviewed.

GNSPS commented 6 years ago

Are you ok with the variable name change, @jchittoda ?

jchittoda commented 6 years ago

Looks good to me. Thanks @GNSPS