search

Consensys / surya

A set of utilities for exploring Solidity contracts
Apache License 2.0
1.08k stars 119 forks source link

Tagomaru feat/draggable #67

Closed maurelian closed 5 years ago

maurelian commented 5 years ago

I made some changes on top of #44, but couldn't figure out how to push to the branch iin @tagomaru's repo. This PR makes a few small changes to the other one.

  1. Removes some dead code (unnecessary imports, and inconsequential try/catch)
  2. Prints the html to stdout. This is consistent with other commands, and enables more flexibility in naming and locating the output file.
  3. Removes unused independencies, including isparta which was triggering an npm audit warning, but doesn't seem like it was being used anywhere.
tagomaru commented 5 years ago

@maurelian

Apologies for 1 and 3.

  1. Prints the html to stdout. This is consistent with other commands, and enables more flexibility in naming and locating the output file.

LGTM! Thx!

GNSPS commented 5 years ago

LGTM