Closed gconnect closed 1 month ago
@rolfyone please take a look when you have the time.
Thanks for raising, will review shortly. One initial comment - We'll only want 'partially addresses' in the 'fixes, because this would otherwise close the issue...
Thanks for raising, will review shortly. One initial comment - We'll only want 'partially addresses' in the 'fixes, because this would otherwise close the issue...
Not sure what you meant here.
We could potentially treat this as a 'tracer' PR and just create a new branch with what we want in the first one... Alternatively we need to remove all of the functionality other than the network yaml change Basically, I need a PR that just changes the network yaml and doesn't break anything when reading the old configuration file that doesn't have the chain id in it... This is really critical, because thats basically ensuring its not a breaking change.
What changes will I apply to the network.yaml file if I am not adding the chainId?
opened a new PR here https://github.com/Consensys/teku/pull/8631
PR Description
Todo
Doing this tends not to work as expected
Still figuring how to handle the check.
Fixed Issue(s)
"fixes #8589"
Documentation
doc-change-required
label to this PR if updates are required.Changelog