Consensys / teku

Open-source Ethereum consensus client written in Java
https://consensys.io/teku
Apache License 2.0
679 stars 284 forks source link

[Draft] Add database reset on Ephemery Network #8626

Closed gconnect closed 1 month ago

gconnect commented 2 months ago

PR Description

Todo

Doing this tends not to work as expected

  final Eth2NetworkConfiguration networkConfig =
        Eth2NetworkConfiguration.builder(Eth2Network.EPHEMERY).build();

    if (networkConfig.getEth2Network().equals(Optional.of(Eth2Network.EPHEMERY))) {
      ....
    }

Still figuring how to handle the check.

Fixed Issue(s)

"fixes #8589"

Documentation

Changelog

gconnect commented 2 months ago

@rolfyone please take a look when you have the time.

rolfyone commented 1 month ago

Thanks for raising, will review shortly. One initial comment - We'll only want 'partially addresses' in the 'fixes, because this would otherwise close the issue...

gconnect commented 1 month ago

Thanks for raising, will review shortly. One initial comment - We'll only want 'partially addresses' in the 'fixes, because this would otherwise close the issue...

Not sure what you meant here.

gconnect commented 1 month ago

We could potentially treat this as a 'tracer' PR and just create a new branch with what we want in the first one... Alternatively we need to remove all of the functionality other than the network yaml change Basically, I need a PR that just changes the network yaml and doesn't break anything when reading the old configuration file that doesn't have the chain id in it... This is really critical, because thats basically ensuring its not a breaking change.

What changes will I apply to the network.yaml file if I am not adding the chainId?

gconnect commented 1 month ago

opened a new PR here https://github.com/Consensys/teku/pull/8631