Consensys / teku

Open-source Ethereum consensus client written in Java
https://consensys.io/teku
Apache License 2.0
678 stars 284 forks source link

Feature: One password file for all validator #8731

Open maximus321 opened 1 month ago

maximus321 commented 1 month ago

Description

It would be nice to have a way to only use one validator password file for all my validator. With a high number of validators, that is easy to achieve now with lido csm, we can have an overwheliming number of .txt file that contains the same information (not optimal)

It would be nice to have an option like --single-password-file:pwd.txt

As discussed on discord here https://discord.com/channels/697535391594446898/697539289042649190/1295781894008471604

Steps to Reproduce (Bug)

[Please be as specific as possible]

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Frequency: [How regularly does it occur?]

Versions (Add all that apply)

rolfyone commented 1 month ago

Hey thanks for raising this. We'll see what we can do to improve the situation.

We do similar too for our validators so I feel like it's a use-case we have worked around and could probably improve, we just may need to specify the keys differently for this new scenario or something, but we'll schedule some time to do some design.

Just for context from others browsing, currently teku supports basically a list of key:password entries https://docs.teku.consensys.io/reference/cli#validator-keys which may be pairs of directories or pairs of files, and we'd be changing to a semantic of specifying the keys in one parameter (files or directory most likely) and taking the password from a separate entry.

The validator-keys cli arg is very commonly used currently, so a solution where current behaviour remains valid would be required. This may mean we end up using a different flag to specify just the keys, and a flag for the one password file, but I won't preclude the design process by 'solutioning' just yet.