Consensys / teku

Open-source Ethereum consensus client written in Java
https://consensys.io/teku
Apache License 2.0
664 stars 283 forks source link

Prometheus Histogram buckets standardization #8739

Open tbenr opened 3 hours ago

tbenr commented 3 hours ago

https://prometheus.io/docs/tutorials/understanding_metric_types/#histogram

the standard appears to be something like:

Bucket Count
0 - 0.3 1
0 - 0.5 2
0 - 0.7 2
0 - 1 2
0 - 1.2 2
0 - +Inf 2

but our implementation (MetricsCountersByIntervals) follows a different approach:

Bucket Count
[0,0.3) 1
[0.3,0.5) 1
[0.5,0.7) 0
[0.7,1) 0
[1,1.2) 0
[1.2,∞) 0
zilm13 commented 3 hours ago

MetricsCountersByIntervals which should be used as a start