change blindedBlockCreatorCache keys from slot to slotAndBlockRoot.

Consensys / teku

Open-source Ethereum consensus client written in Java

https://consensys.io/teku

Apache License 2.0

679 stars 284 forks source link

change blindedBlockCreatorCache keys from slot to slotAndBlockRoot. #8780

Closed david-ry4n closed 2 weeks ago

david-ry4n commented 3 weeks ago

PR Description

Part of fixes for SSV compatibility. Switch cache key from slot to slotAndBlockRoot.

Fixed Issue(s)

Fixes #8625

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr commented 3 weeks ago

I'll ask to one of you why this is needed :)

StefanBratanov commented 3 weeks ago

I'll ask to one of you why this is needed :)

Essentially, it is a bit of protection for future enhancements for zero cost. If we implement replays, best block produced from multiple BN functionalities. Also I think it's more concise. Similar to isLocallyCreatedBlock in the ValidatorApiHandler.

tbenr commented 3 weeks ago

I'll ask to one of you why this is needed :)

Essentially, it is a bit of protection for future enhancements for zero cost. If we implement replays, best block produced from multiple BN functionalities. Also I think it's more concise. Similar to isLocallyCreatedBlock in the ValidatorApiHandler.

ok, sold