Consensys / tessera

Tessera - Enterprise Implementation of Quorum's transaction manager
https://docs.tessera.consensys.net/
Apache License 2.0
175 stars 105 forks source link

update hsqldb to 2.7.1 #1494

Closed macfarla closed 1 year ago

macfarla commented 1 year ago

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

Documentation

Changelog

macfarla commented 1 year ago

Getting 3 errors from running ./gradlew :tests:acceptance-test:compileTestJava locally - to do with something I don't understand in module-info.test

/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible
import org.hsqldb.persist.HsqlProperties;
                 ^
  (package org.hsqldb.persist is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)
/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:5: error: package org.hsqldb.server is not visible
import org.hsqldb.server.Server;
                 ^
  (package org.hsqldb.server is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)
/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:6: error: package org.hsqldb.server is not visible
import org.hsqldb.server.ServerAcl;
                 ^
  (package org.hsqldb.server is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)
macfarla commented 1 year ago

with extra work I am down to one error


/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible
import org.hsqldb.persist.HsqlProperties;
                 ^
  (package org.hsqldb.persist is declared in module org.hsqldb, which does not export it)
macfarla commented 1 year ago

^ so in test we are using a class org.hsqldb.persist.HsqlProperties which is not exported by the org.hsqldb module - not sure if there's a way around this

macfarla commented 1 year ago

luckily there is an overloaded method that accepts java.util.Properties and wraps them into HsqlProperties internally.

macfarla commented 1 year ago

2.7.1 is out so suppression can be removed

macfarla commented 1 year ago

current failures seem to boil down to this

Error occurred during initialization of boot layer
java.lang.module.FindException: Module jnacl not found, required by tessera.encryption.jnacl
Krish1979 commented 1 year ago

closing this as it is fixed with #1498