search

Consensys / truffle-security

MythX smart contract security verification plugin for Truffle Framework
https://mythx.io
124 stars 28 forks source link

Handle global NPM packages #129

Closed rocky closed 5 years ago

rocky commented 5 years ago

Right now we handle locally-install npm packages. But what if openZepplin is installed globally?

tagomaru commented 5 years ago

This concept was implemented at this PR which did not be merged.

rocky commented 5 years ago

So if we merge that, we are then good? Or does this need to be reworked?

tagomaru commented 5 years ago

No, we already merged another one. This is not compatible for that. I work on it at a later date.

rocky commented 5 years ago

The other thing to keep in mind is that if we use truffle-resolve things may change again. It might have to be worked into the NPM module instead of how it would be done now.

tagomaru commented 5 years ago

Yes, thanks, i know. I think we should refer to that to handle npm and EthPM at the same time.

tagomaru commented 5 years ago

@rocky

Right now we handle locally-install npm packages. But what if openZepplin is installed globally?

According to my investigation, truffle itself does not support globally installed package. So i think we do not have to resolve this. I may send PR for supporting globally installed package to truffle-resolver itself at a later date.

rocky commented 5 years ago

Yes, building on truffle-resolver is the way to go.

tagomaru commented 5 years ago

yes i am closing this.