search

Consensys / vscode-solidity-auditor

Solidity language support and visual security auditor for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=tintinweb.solidity-visual-auditor
GNU General Public License v3.0
569 stars 60 forks source link

[Graph] Different styling for Custom Errors #101

Closed C-Mierez closed 1 year ago

C-Mierez commented 2 years ago

Greetings.

This is a bit of niche suggestion perhaps, but I noticed when generating a graph on a contract that has Custom Errors defined, these are graphed the same way as regular functions.

For example, given this contract:

The generated graph is:

I like the idea of having errors showing in the graph, but it would be nice if they had some different styling to tell them apart from actual contract functions.

And as a side-note, it's interesting that events are not included at all. Perhaps that's something that could be looked into as well.

tintinweb commented 2 years ago

@GNSPS can you look into this? you're the king of graphing 🤗 Errors should probably be exempt from the graphing at all, wdyt?

tintinweb commented 1 year ago

opened a discussion with https://github.com/ConsenSys/surya/issues/170. please follow up there.

thanks for reporting & cheers 🙌