Consensys / vscode-solidity-auditor

Solidity language support and visual security auditor for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=tintinweb.solidity-visual-auditor
GNU General Public License v3.0
578 stars 60 forks source link

`funcSig` feature fails when having methods with structs as arguments #155

Open 0xdcota opened 2 months ago

0xdcota commented 2 months ago

With a simple method as show below:

function enableBorrowingOnReserve(address asset, bool stableBorrowRateEnabled) external onlyPoolAdmin

The funcSig feature returns a new file with:

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 
| enableBorrowingOnReserve | eede87c1 | enableBorrowingOnReserve(address,bool) |

The above is great :+1:

Now, the issue is

However, with a complex argument function such as:

function updateAToken(UpdateATokenInput calldata input) external onlyPoolAdmin

The funcSig returns nothing.. :x:

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 

I suppose the challenge is in interpreting: "what is UpdateATokenInput".

The methods above are in the Aave code base if you want to give it a try: https://github.com/aave/protocol-v2/blob/master/contracts/protocol/lendingpool/LendingPoolConfigurator.sol