Consensys / web3js-quorum

30 stars 21 forks source link

fix(typescript): correct type for IDistributeRawTransaction.privateFor #54

Closed petermetz closed 1 year ago

petermetz commented 1 year ago

https://github.com/Consensys/web3js-quorum/blob/eff69e832c6ac1528899d8f969641ff203fa1c4d/src/typescript/index.d.ts#L306

  export interface IDistributeRawTransaction {
    readonly privateKey: string;
    readonly privateFrom: string;
    readonly privateFor: string;
    readonly privacyGroupId: string;
    readonly nonce: string;
    readonly to: string;
    readonly data: string;
  }

Shouldn't this privateFor be an array of keys rather than a single string? If you can confirm that this is the case, then I can send a PR fixing it.

Same question about this interface:

  export interface IPtmSend extends IOptions {
    readonly privateFor: string;
  }

https://github.com/Consensys/web3js-quorum/blob/eff69e832c6ac1528899d8f969641ff203fa1c4d/src/typescript/index.d.ts#L82C1-L84C4