Consensys / web3js-quorum

30 stars 21 forks source link

fix(typescript): make enclaveOptions and isQuorum optional args #55

Closed petermetz closed 1 year ago

petermetz commented 1 year ago

The implementation [1] has the 2nd and 3rd parameters as optional with default values, but the Typescript types are forcing the programmer to provide values due to the typings [2] not mirroring the implementation:

[1] https://github.com/Consensys/web3js-quorum/blob/eff69e832c6ac1528899d8f969641ff203fa1c4d/src/index.js#L41

[2] https://github.com/Consensys/web3js-quorum/blob/eff69e832c6ac1528899d8f969641ff203fa1c4d/src/typescript/index.d.ts#L9