Consensys / web3signer

Web3Signer is an open-source signing service capable of signing on multiple platforms (Ethereum1 and 2, Filecoin) using private keys stored in an external vault, or encrypted on a disk.
https://docs.web3signer.consensys.net/
Apache License 2.0
200 stars 76 forks source link

Added trusted-setup cli arg back in for teku acceptance testing #1016

Closed rolfyone closed 2 months ago

rolfyone commented 2 months ago

I think ultimately this should be less important at some point but if it's present it allows me to actually test some changes now, rather than waiting for future builds that build in some changes to teku that remove the need to define trustedSetup, so ideally it's ok to have this defined as a dev flag for testing for now...

The problem I was having was acceptance-tests use custom configuration and there was no way to specify this argument, so I wasn't able to check deneb for external-signer changes in teku...

I've got another change for teku that should make this less important again (default trusted-setup basically) but it'll be hard to coordinate that change plus external-signer changes without some blocking, unless this flag exists, and then i can just start testing things now.

Given this is hidden i didn't add it to changelog but happy to if needed... The only place calling it will be a teku acceptance test once i merge that...

Documentation

Changelog

Testing