Consensys / web3studio-soy

Static Websites on the Distributed Web
https://medium.com/web3studio/soy-is-the-secret-sauce-for-the-unstoppable-web-6e2c1f37430b
33 stars 5 forks source link

Add healthcheck for root soy website #53

Closed barlock closed 5 years ago

barlock commented 5 years ago

Related Issue
Supports #45

Related PRs
This PR is not dependent on any other PR

What does this PR do?
Add's a health check via route53 to web3stuido.eth.soy/web3studio/. failures are sent to #web3studio-alarms

Description of Changes
Moved the aws code into an aws folder to follow the website's pattern.

I chose to put the health check resources into it's own stack as the gateway takes forever to deploy. This allows for easier changes and testing..

What gif most accurately describes how I feel towards this PR?
fire

barlock commented 5 years ago

It's near identical. Two different endpoints.

In this instance I wasn't sure how to make the code dryer or how honestly... This is where not being a cloudformation expert becomes an issue. On Thu, Jan 24, 2019 at 5:26 PM Brian Chamberlain notifications@github.com wrote:

@breakpointer approved this pull request.

Some of this seems vaguely familiar...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/web3studio-soy/pull/53#pullrequestreview-196280404, or mute the thread https://github.com/notifications/unsubscribe-auth/AFgLFyqH3X0ByIGNw62Pvg6vBsqJNuYsks5vGjMEgaJpZM4aRwHz .