search

ConservationInternational / cplus-plugin

QGIS plugin for using CPLUS framework in effective land-use planning
https://conservationinternational.github.io/cplus-plugin/
GNU General Public License v3.0
3 stars 5 forks source link

Fix report cannot open in online task #458

Closed zamuzakki closed 1 month ago

zamuzakki commented 1 month ago

This is PR for https://github.com/ConservationInternational/cplus-plugin/issues/457

When creating ScenarioAnalysisTask, scenario_id is set to None. Then, on the nex few lines, the scenario_id in progress_dialog is set to match the scenario_id.

This causes progress_dialog's scenario_id to be None. Causing it not detecting the report result once generated.

What I did in this PR, is using different variable to store Online task UUID, so Scenario ID from local stays intact.

I've tested for both online and local processing, they both could now show PDF and Layout Manager.

Demo: https://github.com/ConservationInternational/cplus-plugin/assets/7352963/b88fca0c-9baa-4d6a-b1a0-a50e97c25035

github-actions[bot] commented 1 month ago

badge

Plugin zip package for the changes in this PR has been successfully built!.

Download the plugin zip file here https://github.com/ConservationInternational/cplus-plugin/suites/24628588146/artifacts/1577179436

zamuzakki commented 1 month ago

@danangmassandy @Samweli I've updated the code to use different variable to store Online task UUID, so Scenario ID from local stays intact.

Demo: https://github.com/ConservationInternational/cplus-plugin/assets/7352963/b88fca0c-9baa-4d6a-b1a0-a50e97c25035