ConservationInternational / trends.earth

trends.earth - measure land change
http://trends.earth
GNU General Public License v2.0
111 stars 45 forks source link

Ensure signal is sent to reload layer selection dropdowns on region change #727

Closed azvoleff closed 1 year ago

azvoleff commented 1 year ago

Sometimes if a user changes the region in the settings window from within a dialog box, the layer dropdowns won't reload (for example the "Land cover change" tool for the initial and target year fields below):

image

To reproduce, change the region in settings to one with data available - the dropdowns should then immediately populate with data available for that region, but doesn't consistently do this.

vermeulendivan commented 1 year ago

@azvoleff Want to have a go at this, but unsure what the initial year layer and the target year layer should be. Any guidance you can provide? Busy downloading landcover using the remote execution, but will only be able to have a look once its done. Also, when clicking on the 'Help' at the button righ-hand corner, nothing happens. Is this normal? image

azvoleff commented 1 year ago

@vermeulendivan they are filtered using this code. The filter field and values are stored in the .ui files for each dialogue (different dialogues filter by different bands, and some dialogs filter datasets, not bands)

azvoleff commented 1 year ago

Actually I have this one figured out @vermeulendivan (came across it in another user issue). Should be fixed by f47c2dc8

vermeulendivan commented 1 year ago

@azvoleff Great to hear! Will then ignore this issue.