Closed chadbrower0 closed 1 year ago
Oh my goodness, this is awesome. Thanks so much! I like the mask svg work you did, I think it is fine. Here are some notes on getting it to the finish line:
Opinions aren't updating in the histogram after a slidergram drag. If you drag, and then refresh, the opinion shows up in the right place. It works the first time you add your opinion, but not subsequent drags. Oh! Strangely enough, it works if your opinion is anonymous.
"This will remove your opinion from the histogram, but keep the pros and cons and comments that you have written for this proposal. Are you sure you wish to remove?" This is wrong: in order to post a pro or con point, you need to have a published opinion. So when you delete your opinion, the pros and cons you wrote will be deleted. (Note, I don't think this is the best way to handle it. I think it would be best if it worked like the following: your pros and cons are deleted when your opinion is deleted, if no one else has included them. However, for pros and cons that other people have used, the author of the respective points is re-assigned to a universal "[deleted]" (or something similar) account. (A similar set of problems happens in the rare case that someone deletes their account, which should be handled more gracefully -- comments disappear mid-thread, and pros/cons are deleted regardless of how many people included them.))
When someone has not added their opinion to a proposal yet, I think the area should just read "Add your opinion", instead of "Your opinion: [edit icon]". I think this is better overall, but also fixes the problem where you end up with ["Your opinion:"] on small screens (because of the nice work you did removing the edit icon when the screen width gets small).
It would be nice to give some indicator / reinforce that your opinion is anonymous in the opinion crafting view. Maybe next to the "Remove your opinion" button below the dashed your opinion box. I'll add a mockup.
I'm not sure I like the trash can over a more subtle x
Opinions aren't updating in the histogram after a slidergram drag... it works if your opinion is anonymous.
Fixed in commit 403f9ec
I will continue working on the other modifications.
when you delete your opinion, the pros and cons you wrote will be deleted.
Updated prompts to more accurately describe deletion.
"Add your opinion", instead of "Your opinion: [edit icon]".
Reused the existing getOpinionPrompt() which supplies "Give your opinion". We could change that function to yield "Add your opinion" in all its usages, though I suggest doing that in a separate change that considers the variety of usages of that function.
Because we hide the icon at narrow screen widths, the label had to become a button so that it can function on its own.
in the opinion crafting view... "Remove your opinion" button below the dashed your opinion box. I'll add a mockup.
Implemented per mockup
I'm not sure I like the trash can over a more subtle x
Done
Well, this pull request has a lot of pork in it now, ha. Major changes described at https://traviskriplean.com/lively-anonymity-overhaul-for--bdh9kk.
This change adds buttons in the proposal metadata, to edit / anonymize / delete the participant's opinion. Anonymizing the opinion also anonymizes the partcipant's reasons for the proposal.