fix: Add types field to package.json exports

ConsoleTVs / sswr

🔥 Svelte stale while revalidate (SWR) data fetching strategy

MIT License

234 stars 11 forks source link

fix: Add types field to package.json exports #47

Closed lachlancollins closed 7 months ago

lachlancollins commented 1 year ago

Hi @ConsoleTVs , this is a small PR that improves typescript compatibility. At the moment, publint and ATTW give a warning about the missing exports["."]["types"] field.

What's changed:

Added exports["."]["types"] field
Marked the package as "type": "module" (.js interpreted as ESM)
Added src directory to output (probably not that useful since there aren't sourcemaps but still nice to be able to inspect the source)

lachlancollins commented 7 months ago

Hi @ConsoleTVs, just wondering if you could check out this PR? Thanks!

ConsoleTVs commented 7 months ago

Hi @lachlancollins, Would it be possible to update to Vite 5? I feel this change would also be welcome!

lachlancollins commented 7 months ago

Hi @lachlancollins, Would it be possible to update to Vite 5? I feel this change would also be welcome!

No worries! Since there were 2 lockfiles, I've removed package-lock.json in favour of yarn.lock, and updated Vite and TS. I've put the Svelte v5 alpha in peerDeps.