Closed inzanez closed 3 years ago
What is this node adapter?
Basically a build adapter that will result in an application build for NodeJs instead of a static file build.
Ok, looking a bit more into this, it does seem that this doesn't work with SvelteKit yet. Any idea why that might be? I just started a new project using
npm init svelte@next my-app
cd my-app
npm install
npm run dev
and tried to run the sample code, resulting in the same error described above.
Same here with SvelteKit.
I'm not using node adapter.
So, the adapter is not the problem here.
I think we should initialize sswr before using it and use it with setContext
/getContext
.
Using the steps in https://kit.svelte.dev/docs#introduction-getting-started
you can try yourself: it doesn't work.
Strange, last time I checked it worked... I'll check
I just tried and it does work... 😕
Fresh install and everything...
Can you please create an example
directory with the new Svelte Kit Demo project and sswr?
Wait, I just double checked by installing the remote pkg and you're right it fails. I'm going to see what's going on here... Thanks for the error report, seems it worked fine with my local pkg :D
Do you have any news on this, @ConsoleTVs?
I tries to fix it and i was unable to. I got to the conclusion thst it might either be a bundle issue or something related. I am not an expert but sveltekit api is not yet stable either and it is due change, ao i might either wait for some PR from people who know more about the internals, wait for sveltekit to be stable or in short, have some more free time to allocate to this
It's not a bug in this package, but in sveltekit
. I saw the same problem on my own tinkering with react-query
- so I opened a bug in sveltekit
. See https://github.com/sveltejs/kit/issues/2147.
Btw, it only happens when both preconditions are true: a) lifecycle-method called inside an installed package. b) in dev-mode.
It works in svelte-repl though. So its likely a problem with the vite-dev-server.
PS: You can circumvent the bug for now by installing swrev
and copy sswr to your local $lib-folder and import it from there.
It's not a bug in this package, but in
sveltekit
. I saw the same problem on my own tinkering withreact-query
- so I opened a bug insveltekit
. See https://github.com/sveltejs/kit/issues/2147.Btw, it only happens when both preconditions are true: a) lifecycle-method called inside an installed package. b) in dev-mode.
It works in svelte-repl though. So its likely a problem with the vite-dev-server.
PS: You can circumvent the bug for now by installing
swrev
and copy sswr to your local $lib-folder and import it from there.
That could explain why my local symlinked pkg was working lol
I think this fix it (for now): https://github.com/ConsoleTVs/sswr/pull/11.
Can we close this?
Yes, I hope this will be fixed in the future by svelte plugin authors. Great work!
Hi
I'm trying to use sswr with a newly created SvelteKit project, building with the
node
adapter. I have added some simple test after having had issues:test to a
and I always get back the same error:
Any idea why that might be?