Refactor container-admin docker image

Consonance / consonance

Core consonance utilities for scheduling, reporting on, and provisioning VMs for workflows

GNU General Public License v3.0

14 stars 5 forks source link

Refactor container-admin docker image #118

Closed lmanohara closed 8 years ago

lmanohara commented 8 years ago

Refactored Docker run commands. (https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/).
Waiting time for dependent service's startup is hard coded in the Docker file. dockerize tool used to check whether dependent services are running or not. (https://github.com/jwilder/dockerize).
Expose port 8080 and 8081 from the docker container and map those same ports in docker compose.
Add service startup commands to a separate bash script and call that init.sh from the Docker CMD.

coveralls commented 8 years ago

Coverage remained the same at 41.128% when pulling cabbf64f1b48a883248e1ad586e9762dc8d8fea7 on lmanohara:develop_2 into 33c582e52250f47421751040ada4a00f9ef5327d on Consonance:develop_2.

lmanohara commented 8 years ago

May I know the reason for closing this pull request? because the user should wait until 1h to start up the servers according to this https://github.com/Consonance/consonance/blob/develop/container-admin/Dockerfile#L50

denis-yuen commented 8 years ago

@lmanohara sorry, we've been doing some refactoring, I think the pull request was automatically closed when we renamed develop_2 to develop

lmanohara commented 8 years ago

Sorry, I did not see that. If my pull request is useful, please merge. Thank you for reopening my pull request.

denis-yuen commented 8 years ago

This is now merged as part of that linked pull request (needed to make a couple changes). Thanks!