Reopening @buckyballs PR: Shortest path partitioning

Constellation-Labs / constellation

:milky_way::satellite: Decentralized Application Integration Platform

Apache License 2.0

153 stars 40 forks source link

Reopening @buckyballs PR: Shortest path partitioning #1449

Closed kpudlik closed 3 years ago

buckysballs commented 3 years ago

In the future, please notify the creator of the pr if it was closed accidentally so they can reopen and take credit

kpudlik commented 3 years ago

Unfortunately reopening is not always possible.

If you close the PR accidentally (this is what happened during planning and I realised that 1h ago) and then rebase/force-push the branch then you need to create new one (because Github loses the reference). This is the only reason why I created PR by myself on your branch. But fair point, sorry for that. I could have asked you to recreate that but we just needed that change to be merged earlier to merge Gossip then.

kpudlik commented 3 years ago

And in general history of commits is persisted because we use rebase instead of merge. So there is no "merge commit" created by me but only your commits.