search

Constellation-Labs / constellation

:milky_way::satellite: Decentralized Application Integration Platform
Apache License 2.0
151 stars 40 forks source link

Fallback to eigentrust for SAW. Re-enable SAW & local test #1600

Open ryle-goehausen opened 2 years ago

ryle-goehausen commented 2 years ago

Tested this on cluster.

ryle-goehausen commented 2 years ago

@marcinwadon re-ran scalafmt as well. Should I rebase? It seems like squash commits are required by default, I am happy to just use the commit message from original on a squash commit to avoid having to rebase every time.

marcinwadon commented 2 years ago

@marcinwadon re-ran scalafmt as well. Should I rebase? It seems like squash commits are required by default, I am happy to just use the commit message from original on a squash commit to avoid having to rebase every time.

Yeah, linear history is required. You can either squash and keep the original message, or once updating the pull request, just ammend changes instead of creating a new commit.

ryle-goehausen commented 2 years ago

@marcinwadon ready for review again, just to clarify I usually use the 'Squash and Merge' option in PR page (this webpage) -- that is sufficient right? I think it's required anyways. I'll squash with original commit message