search

Consti10 / FPV_VR_OS

Latest version of FPV_VR, open source under LGPL
GNU Lesser General Public License v2.1
66 stars 26 forks source link

Build is failing #6

Open muzy opened 4 years ago

muzy commented 4 years ago

Hi there,

the build with the current latest commits on the respective master branch of project dependencies fails in the task :app:externalNativeBuildDebug with the following error:

In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.cpp:8: In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.h:53: C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\VSYNC.hpp:56:41: error: no member named 'getNSamples' in 'AvgCalculator' In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.cpp:8: In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.h:53: C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\VSYNC.hpp:65:49: error: no member named 'getNSamples' in 'AvgCalculator' In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.cpp:8: In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.h:53: C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\VSYNC.hpp:66:71: error: no member named 'getAvg' in 'AvgCalculator' In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.cpp:8: In file included from C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\FBRManager.h:53: C:\Users\Sebastian\fpv_vr_latest\RenderingX\RenderingXCore\src\main\cpp\SuperSync\VSYNC.hpp:68:86: error: no member named 'getAvgReadable' in 'AvgCalculator'

Building RenderingX Example application worked fine though. I am using the latest Beta of Android Studio (4.1 Beta 5) as the regular stable version of Android Studio seems incompatible with the gradle files.

Could you please consider creating a tag or release for every project that FPV_VR_OS uses. to have stable dependencies? This would greatly reduce the complexity in debugging builds and adding to the software.

Thank you!

Consti10 commented 4 years ago

Hello, I pushed all my recent commits to FPV_VR,RenderingX and LiveVideo10ms, such that you can at least build the project. Since RenderingX and LiveVideo10ms both have native and java code I cannot just assign a version code and publish the project on jitpack. Google prefab looks promising & might make that easier, but right now I am stuck with 3 different repos on Github.

For now I'd recommend to use the latest commit(s) on the master branch, if there are any problems I'l get it fixed quickly.

muzy commented 4 years ago

Hi,

thank you for your incredibly fast response and fix! This is very much appreciated :) The build did work well with the following commit hashes and versions (just in case someone needs this information in the future):

Android Studio: 4.1 Beta 4
Android Gradle Plugin Version: 4.1.0-beta05 (6.5)
FPV_VR_OS: fe0a4b25fe0a83985c8ed0fbb63d0e742bcf1b3b
LiveVideo10ms: f7b43cc718ee7bf523c0a0bb2892a29507756003
RenderingX: 3aeec5343a04782d4a1843514c866f3a7cd713b7

Regarding git tag/releases I now understand that there is a relationship between tags and jitpack. Maybe it is feasible to assign tags to the individual project commits such as _fpv_vrvX.Y.Z. in all projects to show users that the the commit is recommended (and maybe tested) for building the specific version of the FPV_VR_OS project.

Thank you for this incredible project!