search

Constructor-io / constructorio-client-javascript

Constructor.io JavaScript client for web applications
https://constructor.io
MIT License
17 stars 5 forks source link

[CSL-2646] Added Item Tracked Purchase type #308

Closed HFaifman closed 7 months ago

HFaifman commented 7 months ago

Added new Item Tracked Purchase type that includes price and count properties.

HFaifman commented 7 months ago

The failed test doesn´t seem to be related to these changes.

HFaifman commented 7 months ago

I see we're passing items as is to the API but it's not apparent what items contains apart from the types. Can we document the items attributes here so it's clear what items should look like in the docs as well as the types

https://github.com/Constructor-io/constructorio-client-javascript/blob/csl-2646-js-client-sdk-switch-to-using-count-for-purchase-events/src/modules/tracker.js#L1083

This makes a lot of sense. Yes, I´ll add it to this PR. EDIT: This should be taken care of.