Fixes for 5.2(?) - Githubissues

ConsultingMD / activerecord5-redshift-adapter

Other

45 stars 155 forks source link

Fixes for 5.2(?) #24

Closed andyklimczak closed 4 years ago

andyklimczak commented 5 years ago

Using Rails 5.2.2, Activerecord 5.2.2, Ruby 2.5.1
Ran into a few issues where AR was giving back incorrect number of params that wouldn't allow redshift to migrate

Related to #23

jerryclinesmith commented 5 years ago

Any chance we can get this merged and a new gem released?

tjsingleton commented 4 years ago

This pull request has been closed because it has not had recent activity.

andyklimczak commented 4 years ago

Closing because it's not correct or closing because fixed in another PR?

I'm happy to try to do any updates that need to be done

jerryclinesmith commented 4 years ago

I'm confused... We asked for a release to get this fix, no release was made, and it's closed for inactivity? Can a new gem be released with this fix then we close this?

andyklimczak commented 4 years ago

It seems like this other PR solves the same issues, and more: https://github.com/ConsultingMD/activerecord5-redshift-adapter/pull/29

So it might be better if anyone finds this