ConsumerDataStandardsAustralia / product-comparator-demo

A PoC of banking products view/comparison web app utilising the open banking product API
MIT License
39 stars 75 forks source link

Loan Purpose in Lending Rate is not formatting correctly #242

Closed gobravedave closed 9 months ago

gobravedave commented 10 months ago

Description When viewing load rate the Loan Purpose value it not formatting correctly.

eg. Loan Purpose OWNER_OCCUPIED

Possible value are.. loanPurpose | INVESTMENT loanPurpose | OWNER_OCCUPIED

Suggested Changes

utils/dict.js

  export const loanPurposeDict = {
  INVESTMENT: 'Investment',
  OWNER_OCCUPIED: 'Owner Occupied'
}

  export const translateloanPurpose = (loanPurpose) => loanPurposeDict [loanPurpose]

LendingRate.js

import {translateInterestPaymentDue, translateLendingRateType, translateRepaymentType, translateloanPurpose  } from '../../../utils/dict'

 {!!loanPurpose && <div>Loan Purpose {translateloanPurpose (loanPurpose)}</div>}
vadkor commented 9 months ago

Resolved by #243