search

ConsumerDataStandardsAustralia / standards-maintenance

This repository houses the interactions, consultations and work management to support the maintenance of baselined components of the Consumer Data Right API Standards and Information Security profile.
41 stars 9 forks source link

cds_banking.yaml & cds_banking.json both reference a definition which does not exist. #454

Closed tomred-net closed 2 years ago

tomred-net commented 2 years ago

Description

cds_banking.yaml & cds_banking.json both reference a definition which does not exist.

Specifically cds_banking.yaml refers to $ref: '#/definitions/ResponseBankingProductList':1472 which does not exists in definition. This I expect is a bug as ResponseBankingProductList seems to have been replaced by ResponseBankingProductListV2.

Area Affected

cds_banking.yaml:1472 cds_banking.json:1676

  /banking/products
    responses:
      "200": 
        schema:
          $ref: '#/definitions/ResponseBankingProductList'

Change Proposed

cds_banking.yaml:1472 $ref: '#/definitions/ResponseBankingProductList' > $ref: '#/definitions/ResponseBankingProductListV2'

cds_banking.json:1676 "$ref" : "#/definitions/ResponseBankingProductList" > "$ref" : "#/definitions/ResponseBankingProductListV2"

  /banking/products
    responses:
      "200": 
        schema:
          $ref: '#/definitions/ResponseBankingProductListV2'
CDR-API-Stream commented 2 years ago

@tomred-net Thank you for raising this issue.

This change was incorporated into release v1.16.0.

The cds_banking swagger files have been updated so the ResponseBankingProductListV2 definition is used. This can also be reflected in the schema documentation:

image