ConsumerDataStandardsAustralia / standards-staging

Other
1 stars 0 forks source link

Enhancements to Banking documentation #395

Open nils-work opened 2 months ago

nils-work commented 2 months ago

The Banking Candidate Standards included a number of minor documentation enhancements that can be incorporated into the main Standards without changing meaning. Aligning these changes would improve the binding Standards and make any comparison between the two versions more straightforward.

For example, the current statements:

would become:

perlboy commented 1 month ago

I question whether the description should have this sort of info in it. Does a boolean need an explanation? For the "if absent" parts it could be just as well served with the openapi default field as this is the implied value if the server does not receive a value from the client.

nils-work commented 1 month ago

That's a good point @perlboy. Most Booleans do have simpler descriptions than that one though, and some have additional qualifying text for a default. We could consider simplifying as we go through, but would need to be more careful with any rewording to ensure the interpretation doesn't change and further guidance on specific fields is not needed.

Do you think changing this description for the isDetailAvailable Boolean:

True if extended information is available using the transaction detail end point. False if extended data is not available

to this, would be an improvement?:

Whether extended information is available using the transaction detail endpoint

Many Banking fields do have a default specified, but those values are not currently rendered to the documentation. Do you think displaying them in a consistent way would be valuable? There is a handful of fields missing a default where it could be specified, and others describe a more complex default that may need to be considered, like:

If absent defaults to newest-time minus 90 days.

nils-work commented 1 week ago

The changes incorporated with this issue include:

Also note: