ContaAzul / creditcard.js

A simple credit card validation library in JavaScript
http://contaazul.github.io/creditcard.js/
Other
376 stars 81 forks source link

added new bins to 'MasterCard' #44

Closed ronaldoflima closed 8 years ago

ronaldoflima commented 8 years ago

New initial digits will be available in October for Mastercard : 222100 - 222199 222200 - 222999 223000 - 229999 230000 - 269999 270000 - 271999 272000 - 272099

cacontinuos commented 8 years ago

You changed source files, but no tests were changed.

It might be OK if this is a refactory and no behavior has changed, otherwise, please add a test to guarantee that your code works.

cacontinuos commented 8 years ago

@rnldfll, thanks for your PR! By analyzing the blame information on this pull request, we identified @fernahh to be a potential reviewer

fernahh commented 8 years ago

@rnldfll do you have reference about this information?

ronaldoflima commented 8 years ago

@fernahh Yes, I received an email from a card service that uses the Mastercard and i'm using an Apache 's validator that already contains this information . Link below: https://commons.apache.org/proper/commons-validator/apidocs/src-html/org/apache/commons/validator/routines/CreditCardValidator.html#line.56

@aureliojargas Is wrong in the PR description, the regex is ok i think. Sorry for the mistake. Please check the link above and confirm that. About the parenteses you're right, Thanks.

fernahh commented 8 years ago

@rnldfll I'm awaiting your improvements identified by @aureliojargas, ok?

ronaldoflima commented 8 years ago

@fernahh Done

aureliojargas commented 8 years ago

@rnldfll You have removed the outer parenthesis, not the inner parenthesis. Please see my previous comment.

fernahh commented 8 years ago

@rnldfll ping

aureliojargas commented 8 years ago

:+1:

fernahh commented 8 years ago

Thanks for PR, @rnldfll! Next week we will release a new version.