BUG: System initializes its own engine

ContactEngineering / Adhesion

Cohesive zone models and intermolecular interactions for contact calculations

https://contactengineering.github.io/Adhesion/

MIT License

5 stars 2 forks source link

BUG: System initializes its own engine #51

Closed sannant closed 3 years ago

sannant commented 3 years ago

https://github.com/ContactEngineering/Adhesion/blob/85516ea1a4dd9a796ba89294694687c241f0f4b9/Adhesion/System/Systems.py#L77-L80

The biggest problem is that this engine is always serial ... Explaining why my recent simulations needed a surprisingly high amount of memory when running in parallel.

I just need to replace with substrate.engine

sannant commented 3 years ago

I need to check if Adhesion needs separate buffers

of course yes, since they are halfcomplex and in substrate they are not