ContactEngineering / ContactMechanics

Contact mechanics using elastic half-space methods
https://contactengineering.github.io/ContactMechanics/
MIT License
21 stars 5 forks source link

Unify Topobank contact Mechanics analysis and hardwall script #60

Open sannant opened 2 years ago

sannant commented 2 years ago

They mostly do the same thing, I think we can make them use the same helper funcrtions.

This will avoid fixing the same issues at two different places.

And will unify the outputs of webapp and the command line tool.

This is ideal for users switching from contact.engineering to power-user.

sannant commented 2 years ago

Also we have bad code style at some places:

https://github.com/ContactEngineering/ContactMechanics/blob/77b98c1ec52425d5a8a6a7c2f3d583bbbd87fd73/commandline/hard_wall.py#L180-L187

pastewka commented 2 years ago

This is related to #44

pastewka commented 2 years ago

See also #66 that implements a pipeline function for this. The hard wall script should use that function.